Continuing the discussion from Donations for the foundation:
In this post I said that we are missing resources to maintain and improve the infrastructure on which the Tryton development is done.
For me the principal issue is that Rietveld our codereview tool is still based on Python 2. On the server side it is not yet an issue because the appengine of Google is supporting Python 2. On the developer side it may become an issue because upload.py
is also only Python 2 and many distribution are already planning to remove Python 2 (for which support has ended).
We have at many times tried to find a replacement:
I would say that after having searched and tested many tools, I could not find an Open Source tools that could replace Rietveld out of the box.
I came to the conclusion that we must build our codereview tool based on our existing infrastructure.
So the idea is to have an application website (probably Python-Flask-Bootstrap) that is linked to our Roundup by sharing login, session etc. (maybe a subpath like bugs.tryton.org/review
). This application will take from its URL parameter the id of a patch file in roundup and display it for review (using difflib
). We may add some javascript to record and display comments par line. And finally an action to send by email the comment to the user watching the review.
To upload the patch, we could have a simple python script in tryton-env
that send by email to bugs@tryton.org
the mercurial diff of the repository to the proper issue. Of course the basic submission by the roundup web page will work also.
Finally we could trigger a build on drone.tryton.org through trypod.tryton.org, send failure to the author and retrieve the status as badge next to the patch.
Once the basis are there, we could continue to improve it with:
- grouping patch under a history navigation
- integrate review-bot
- patch reformatting with proper commit/author header
- early merge conflict
At B2CK we estimate that we could build the basis of such tool in 2 weeks of development.