Iâm quite glad to see the website efforts. Looks good. And nice to see many people contributing to it.
These are my observations:
The contrast of links were not so nice on my screen and to my eyes. Running google lighthouse for home page and download page also pointed that the linksâ contrast ratio is not optimal.
Home
Text contrast for the first banner subtitle (Modularity, scalability & security for your business) looks weird on my screen.
Animations are a bit slow for my taste. It feels like I have to wait for the content to appear.
Get Tryton
It is not clear that there is a desktop client for linux, as the section for desktop clients does not mention it.
If there is a focus in non-technical people accessing the website, it seems to me that Desktop client is more relevant than docker image and should come first.
For the packages section, it should be mentioned what are each of those packages
The link to PyPi could include the search query for Tryton to make it more relevant.
Addition
It could be interesting to have the logo of different systems and platforms Tryton supports: Windows, Mac, Linux, Docker, Browser. Or point out somehow the flexibility Tryton has.
But it is not ready-to-use. I think we will add it if someone provides a way to build one.
A desktop client is useless if there is no server. The docker image contains the server and a client so it is more accessible (and also very common today).
We can not list 150 packages and it will be unmaintainable as new one are created every month.
The link uses the classifier Tryton which is a better option than a query search.
All remarks have been applied and there is now the âservice providersâ page.
I plan to make the âbecome a service providerâ, âhow to developâ and âcommunication channelâ pages for the week end than I think we could make the switch. We will complete after that the success stories one by one because I think they all need to be reworked to be more attractive and follow the same patterns.
I have just finished looking at the last 4 pages, and here are some suggestions for changes that you might want to consider. Iâm sorry this list is so longâŠ
/develop
TL;DR: Consider changing âSubmit your patchâ to âSubmit a patchâ.
Report Issue:
Change âReport Issueâ to âReporting Issuesâ.
Submit Change:
Change âSubmit Changeâ to âSubmitting Changesâ.
Consider changing the points to:
Follow the coding guidelines.
Submit your patch to our code review tool using one of the methods listed below.
Make sure the review has the repository name at the start of the codereview message, and ensure the review description contains a reference to the issue (e.g.: issue1234).
Once accepted your review will be validated with a LGTM comment from a core developer.
Your change will then be commited and pushed by a core developer. The commit message will be the review subject (with repository name stripped) and the review description. The reference to the review (e.g.: review123456) will be automatically added to the commit message.
Close the review once your patch has been applied.
Submit Change (Script):
Change âDownload upload.py and see the help page.â to âDownload upload.py and read its help page.â
Submit Change (Mercurial Extension):
Change âEdit the file as:â to âEdit the file to include:â.
Change âThen you can upload your patchâ to âYou can then upload your patchâ
Change âdo not commit before uploadâ to âdo not commit before doing thisâ.
Change âthe series number to repository nameâ to âthe series number to the repository nameâ.
Publish Change:
Change âPublish Changeâ to âPublishing Changesâ.
Change âPush to remove serverâ to âPush to the remote serverâ.
Change âIt happens because your local repositoryâ to âThis happens because your local repositoryâ.
Change âKeep the environment repository always up to date with all subreposâ to âAlways keep the environment repository up to date with all the subreposâ.
Coding Guidelines (Python):
Change âCode style follows in general PEP8â to âCode style, in general, follows PEP8â
Coding Guidelines (Recommended Practices):
Change âdefine all pool objects it will usedâ to âdefine all pool objects that will be usedâ.
Coding Guidelines (Naming of modules, classes, variables):
Change âAvoid unnecessary duplicate of namesâ to âAvoid unnecessary duplication of namesâ.
Change âFirst part left of the name is the general functioning of the module or modelâ to âFirst part of the name is the general function of the module or modelâ.
Change âafter this comes the less general name parts (= the more specific name parts) of the module or modelâ to âafter this come the less general parts of the name (i.e. the more specific parts of the name) for the module or modelâ
Change âIf you are unsure with naming, please request first on the mailing listâ to âIf you are unsure with naming, please ask first on the mailing listâ.
Change âFor modules and method names use underscore for separating the name partsâ to âFor modules and method names use an underscore to separate the parts of the nameâ.
Requirements:
Consider changing âYour contribution should meet the following requirementsâ to âYour contribution must meet the following requirementsâ.
Change âBy submitting patchâ to âBy submitting a patchâ.
Rules:
Change âBigger fixes need approval from other core developer.â to âBigger fixes need approval from other core developers.â
Change âin case of disagreementâ to âin the case of disagreementâ
Change âsecurity bugs which are applied at once on all affected seriesâ to âsecurity bugs which are applied at once to all affected seriesâ.
/forum
Forum: Change âcommunication medium in the community is on our forumâ to âcommunication method for the community is our forumâ
Forum: Change âWe discuss new features, provide to each others supportâ to âWe discuss new features, provide each other with supportâ
IRC: Change âwe have multiple channels on freenode networkâ to âwe have multiple channels on the freenode networkâ.
Mailing Lists: Change âThey are listed here for archiveâ to âThey are listed here for referenceâ.
/service-providers
I am reluctant to suggest too many changes to the items on this page as I donât really feel like it is my place to be telling these companies how to describe themselves. Having said that, here are some suggested changes, that they/you might want to consider.
Adiczion: âSpecialist in integration of the Tryton ERPâ to âSpecialists in integration of Tryton ERPâ.
Adiczion: âaccompanimentâ? Perhaps they meant âsupportâ?
Adiczion: âdevelopment of functional complement around this solutionâ? Perhaps they mean something like âdevelopment of functionality around your chosen solutionâ?
B2CK: âas long as advanced core featuresâ to âas well as advanced core featuresâ.
B2CK: âB2CK provides also supportâ to âB2CK also provides supportâ.
Coopengo: No changes.
Datalife: No changes.
First Telecom: No changes.
gcoop: âSince 2011 we work with the Tryton system and contribute to this community.â to âSince 2011 we have worked with the Tryton system and have contributed to its community.â
Lava Lab Software: No changes.
m-ds: âAs its roots in cross-plattformâ to âWith its roots in cross-platformâ.
m-ds: âPython development in special Zope/Plone competenceâ to âPython development, and a special competence in Zope/Ploneâ.
NaN-tic: No changes.
SlSalp: âSISalp provides following servicesâ to âSISalp provides the following servicesâ.
SlSalp: âservices from best contributorsâ to âservices from the best contributorsâ.
Virtual Things: âThe active promoterâ to âAn active promoterâ
Virtual Things: âintegration phaseâ to âintegration phasesâ.
/service-providers/start
Change âlisted as a service providers?â to âlisted as a service provider?â.
1 Contribute: Change âreputation of expertize inside the communityâ to âreputation for expertize within the communityâ.
2 Request Listing: Change âOnce you think you have reach a good level of reputationâ to âOnce you think that your reputation has reached a high enough levelâ.
4 Keep up to date: I am not exactly sure what is meant by âand keep update yours.â, so Iâm guessing you meant âand keep your existing success stories up to dateâ. However an alternative could be âand keep your company information up to dateâ (suggesting you should keep your company information on the service providers page up to date), or âand keep your company information and existing success stories up to dateâ.
Other things that I noticed:
On the service-providers page there is a blank card just below the title at the top, and inside the section containing the title.
On the develop page, the items âClone the repositoryâ, âMake your modificationâ, âSubmit your patchâ, seem like they should be three items in a list. However âClone the repositoryâ appears larger, and âMake your modificationâ and âSubmit your patchâ are shown one after the other on the same line. Perhaps they should all be made the same as the âClone the repositoryâ, each on its own line?
On the forum page the âBe considerate of others, follow the netiqueteâ is right at the bottom of the page, and not in any section. Perhaps it should be higher up, or if it only applies to the mailing lists then maybe it should be in the mailing list section?
I can see your point, I guess that I see it slightly differently. I like the way you have changed it to âSubmit your changeâ.
Ah, okay, then you might want to say âReport an Issueâ, âSubmit a Changeâ and âPublish a Changeâ.
Okay, thatâs fine, I only suggested it as it is described as âTryton Code Review Toolâ on the https://codereview.tryton.org/ page.
Yes, that sounds like very likely, but it seems to be working fine now. Thanks.
Just looked through the updated pages, and noticed a couple of very minor things that might have got lost in the mass of suggested changes:
/develop: Submit change: âOnce accepted your review will be validated with a LGTM comment from a core developersâ the âsâ at the end of âdevelopersâ should be removed.
/develop: Publish change: Change âPush to the remove serverâ to âPush to the remote serverâ.
/develop: Backporting: Change âonce to all affected series followed a releaseâ to âonce to all affected series following a releaseâ.
/service-providers/start: Keep up to date: Change âsubmit new success stories and keep update yoursâ to âsubmit new success storiesâ.
/forum: forum: Change âprovide each other supportâ to âprovide each other with supportâ.
/forum: mailing lists: One I might have missed earlier, change âWe have also some mailing listsâ to âWe also have some mailing listsâ.
The website is on line now.
Thanks everyone for the contribution and review.
Further changes (like rewrite of success stories or topic descriptions) will go through the workflow: Tryton - How to Develop