In the Core Quality module, I have a question about the workflow when an inspection fails. Currently, the module only has one permission group that gives full access to everything related to inspections, including deletion, and it grants access to two buttons: Fail and Pass.
Here’s the behavior I’ve observed:
When an inspection fails because one of the points is incorrect, any user with this permission group can later mark it as passed.
On the other hand, when an inspection fails, an alert is created.
The system blocks the process (e.g. production) until the alert is resolved, showing the message: “To continue, alerts from failed inspections must be resolved.”
Once the alert is resolved, the inspection allows production to continue normally.
My questions are:
What is the correct workflow in these cases?
Should we directly use the Pass button once the issue is fixed, or is the proper procedure to handle and close the alert first before continuing?
Also, should everyone in the current permission group be allowed to perform these actions, or would it be better to separate permissions so that not everyone can “pass” failed inspections without resolving alerts first?
From my point of view, the current workflow is confusing, because it’s possible to reach the same final state — where the record that created the inspection sees it as “closed” and “approved” — in different ways.
For example, a user can pass an inspection that failed, or set it back to “pending”, fix some data, and then pass it again. In both cases, the result is the same, but there is no clear control over who can do this.
I think failed inspections should not be passed directly. They should be set back to “pending”, corrected, and reprocessed. Also, only authorized users should be able to approve an inspection that was previously failed.
Regarding alerts, they are already created when an inspection fails, but they are never cleared automatically. It might make sense to link them better with the inspection workflow — for example, removing the alert automatically when the related inspection is successfully revalidated.
there is no problem with access right. The “Pass”/“Fail” buttons are restricted to the quality group. So overriding the inspection result is limited.
any user can reset to pending the inspection but it is not a problem as we have logs and it is aligned with the Trytonn design.
deleting/cancel alert on passing is questionable because alert created by the automatic failure (even if reset later) may be subject to investigation by the quality team. But of course there is the failure by mistake by the quality users which could be deleted without loosing important information but it is complicated to make the distinction. And the quality users can themselves delete or resolve the alert in such case.
Thanks for reviewing it.
If i’m not wrong the ‘pending‘ button is restricted to the quality group too, as this group is the only one that gives access to the Inspections menu.
So you can not give access rights to “Pass”/“Fail” buttons and “Pending“ separately. They have the same level of restriction.