Test with secondary unit in purchase

Support Developer
1

Hi,

I’m doing tests with proteus on purchase_secondary_unit and it seems the behavior is not the same as with the demo.

I’m just adding two lines in the existing scenario after line 93:

    >>> line.secondary_unit = gr
    >>> line.secondary_quantity
    2000.0

...
Check secondary unit::

    >>> line.product_supplier = product_supplier
    >>> line.quantity = 10

    >>> line.secondary_unit = kg
    >>> line.secondary_quantity
    2.0
    >>> line.secondary_unit = gr
    >>> line.secondary_quantity
    2000.0
    >>> line.secondary_unit_price
    Decimal('15.0000')
    >>> line.secondary_unit_price = Decimal('20')
    >>> line.unit_price
    Decimal('4.0000')
...

and i have this error:

File "/home/mrichez/Workspace/tryton/tryton_custo_dev/trytond/trytond/modules/purchase_secondary_unit/tests/scenario_purchase_secondary_unit.rst", line 95, in scenario_purchase_secondary_unit.rst
Failed example:
    line.secondary_quantity
Expected:
    2000.0
Got nothing

When doing test in the demo, secondary quantity is updated when switching secondary unit.
Am I doing something wrong in the proteus scenario ? Should I force an ‘on_change…’ ?
Thanks.

2

It seems I have to add a line with secondary unit as None in the test before to switch to another unit.

...
Check secondary unit::

    >>> line.product_supplier = product_supplier
    >>> line.quantity = 10

    >>> line.secondary_unit = gr
    >>> line.secondary_quantity
    2000.0
    >>> line.secondary_unit = None
    >>> line.secondary_unit = kg
    >>> line.secondary_quantity
    2.0
    >>> line.secondary_unit_price
    Decimal('15.0000')
...
3

By changing only the secondary unit but keep the secondary quantity, you force a recalculation of the quantity.
I guess in your example the quantity is below the precision so it is rounded to 0.
Now the computation of the secondary quantity is testing if there is a quantity before computing it so it does not compute as it is 0.
I guess we could test against None instead to have also a 0 as secondary quantity.

1 Like
4

Not sure about the quantity below the precision…
In my example:

10 units = 2000 gram (secondary unit)

I switch secondary unit to Kilogram, so we have 2000 Kilogram (if secondary quantity is kept), in this case it should be 10000 units, no ?

So it seems not to be a precision problem.

5

Not in your first example, you switch from kg to gr so from 2kg to 2gr.

6

Indeed.

I was focused on the second example which is the same as modules/purchase_secondary_unit/tests/scenario_purchase_secondary_unit.rst in
Set secondary unit as default on purchase/sale line if defined on product customer (!2294) · Merge requests · Tryton / Tryton · GitLab

7

I’ve updated the test, the error happens after switching secondary unit to kg and testing secondary quantity and I’m understanding the behavior and my mistake.


Failed example:
    line.secondary_quantity
Expected:
    2.0
Got:
    2000.0

So line.quantity is correctly updated from 10 to 10000 when switching secondary unit from ‘gram’ to ‘Kilogram’ and then secondary quantity is also updated from quantity. So, 10000 units is equal to 2000 Kilogram (quantity has priority over secondary quantity). I thought when I switched secondary unit that secondary quantity will be kept and quantity will be updated following secondary quantity. but it’s the inverse: quantity is first updated and then secondary quantity is updated.

...
Check secondary unit::

    >>> line.product_supplier = product_supplier
    >>> line.quantity = 10

    >>> line.secondary_unit == gr
    True
    >>> line.secondary_quantity
    2000.0
    >>> line.secondary_unit = kg
    >>> line.quantity
    10000.0
    >>> line.secondary_quantity
    2.0 ->>> Incorrect (it should be 2000.0)
    >>> line.secondary_unit_price
    Decimal('15.0000')
...