Import from countries in French

Support Developer
1

With this new version (5.8), when importing countries in French (use of the import_countries.py script) I have the following error message:

... $./modules/country/scripts/import_countries.py -d test10 -c trytond.conf
/usr/lib/python3/dist-packages/ldap3/utils/ciDict.py:30: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
  class CaseInsensitiveDict(collections.MutableMapping):
/usr/lib/python3/dist-packages/html5lib/_trie/_base.py:3: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
  from collections import Mapping
/home/xt0ph/.virtualenvs/Tryton-5.8/lib/python3.7/importlib/_bootstrap.py:219: ImportWarning: can't resolve package from __spec__ or __package__, falling back on __name__ and __path__
  return f(*args, **kwds)
Update countries
Update countries fr
Update subdivisions
Update subdivisions parent
Update subdivisions fr
Traceback (most recent call last):
  File "./modules/country/scripts/import_countries.py", line 175, in <module>
    run()
  File "./modules/country/scripts/import_countries.py", line 171, in run
    main(args.database, args.config_file)
  File "./modules/country/scripts/import_countries.py", line 151, in main
    do_import()
  File "./modules/country/scripts/import_countries.py", line 161, in do_import
    translate_subdivisions(subdivisions)
  File "./modules/country/scripts/import_countries.py", line 145, in translate_subdivisions
    Subdivision.save(records)
  File "/home/xt0ph/Documents/technique/tryton/clients/coppernic/ate/proteus/proteus/__init__.py", line 104, in newfunc
    return self.func(owner, *args, **kwargs)
  File "/home/xt0ph/Documents/technique/tryton/clients/coppernic/ate/proteus/proteus/__init__.py", line 858, in save
    proxy.write(*values)
  File "/home/xt0ph/Documents/technique/tryton/clients/coppernic/ate/proteus/proteus/config.py", line 188, in __call__
    result = rpc.result(meth(*args, **kwargs))
  File "/home/xt0ph/Documents/technique/tryton/clients/coppernic/ate/trytond/trytond/modules/country/country.py", line 250, in write
    super(Subdivision, cls).write(*args)
  File "/home/xt0ph/Documents/technique/tryton/clients/coppernic/ate/trytond/trytond/model/modelsql.py", line 159, in wrapper
    return func(cls, *args, **kwargs)
  File "/home/xt0ph/Documents/technique/tryton/clients/coppernic/ate/trytond/trytond/model/modelsql.py", line 1039, in write
    cls._validate(sub_records, field_names=all_field_names)
  File "/home/xt0ph/Documents/technique/tryton/clients/coppernic/ate/trytond/trytond/model/modelstorage.py", line 80, in wrapper
    return func(*args, **kwargs)
  File "/home/xt0ph/Documents/technique/tryton/clients/coppernic/ate/trytond/trytond/model/modelstorage.py", line 88, in wrapper
    return func(*args, **kwargs)
  File "/home/xt0ph/Documents/technique/tryton/clients/coppernic/ate/trytond/trytond/model/modelstorage.py", line 1299, in _validate
    **error_args))
trytond.model.modelstorage.ForbiddenCharValidationError: The value "    Tchoukotka" for field "Nom" in "Subdivision" contains some invalid chars "'\t'". -

I know that the error is in the translation of the sub-divisions of the ‘iso-codes’ project (I also suggested a correction) but this prevents the importation into the Tryton database.
Could we consider cleaning up the string in the import_countries/py script before importing into Tryton?

2

I think it should be first reported to pycountry because tab in subdivision name is wrong.
And yes we could clean data by removing invalid character like tab if pycountry is not clean.

3

By the way this is not 5.8, the char validation has been added after the release of 5.8: Product with newline in name is lost (#9248) · Issues · Tryton / Tryton · GitLab

4

sorry for the confusion.

5