It’s because I have sale lines with data for sub-components that I do not want to be seperately listed on the delivery note/invoices (not all of those will be added as product kits though for maintainability reasons).
risky as in? potentially removal of product-> sale line (type comment) link or something like that? [because at the moment that data is kept in the Sale Line anyway if the type were to be changed after selecting a product).
But that aside … I just am thinking if I make sure I have all the data needed on the report in my extra fields (that are there anyway) then even if the product link was gone i wouldn’t really care. so I could just have the user select the product so that the data gets filled in on on_change_product and then the extra fields for my report are already filled anyway. So unless I am missing any fields there (which I can easily fix) then you are right that I probably wouldn’T need the product → sale line link anymore.
From a quick test I can see that the only fields I would need for me report after on_change_product was called would be uom and amount. the rest is not needed either. if all I need to do is copy that to another field then that is definitely easier
I’m going to check that later and will probably just go with that - then that wouldn’t even require any modifications to the existing code as well so less testing needed.
Thanks for pointing this out . sometimes some brainstorming really helps simplifying stuff and avoiding implementing unneeded stuff