# Tax identifier configuration values not migrated

**URL:** https://discuss.tryton.org/t/tax-identifier-configuration-values-not-migrated/7424
**Category:** Developer
**Tags:** party
**Created:** [July 3, 2024, 11:50am UTC](https://discuss.tryton.org/t/tax-identifier-configuration-values-not-migrated/7424 "2024-07-03T11:50:27Z")
**Posts on this page:** 6
**Page:** 1

<div class="post-metadata">

### Author: ![acaubet](https://discuss-cdn.tryton.org/user_avatar/discuss.tryton.org/acaubet/32/1493_2.png) [@acaubet](https://discuss.tryton.org/u/acaubet)
#### Post date: [July 3, 2024, 11:50am UTC](https://discuss.tryton.org/t/tax-identifier-configuration-values-not-migrated/7424/1 "2024-07-03T11:50:27Z")

</div>

In this version migration, there’s also an [automatic migration](https://foss.heptapod.net/tryton/tryton/-/blob/f41c9c208d399be7f07c1e3b7c3cc3704880e055/modules/party/party.py#L815) from some [identifers](https://foss.heptapod.net/tryton/tryton/-/blob/f41c9c208d399be7f07c1e3b7c3cc3704880e055/modules/party/party.py#L454) to `_vat` suffix identifier.

With a lot of certainty, you will be missing the new \_vat identifier on your party configuration `identifier_types` field.

You can check the ones needed to pick running this query:

```auto
select type from party_identifier where type like '%_vat' group by 1;

```

Otherwise you will have invalid domain records.

---

<div class="post-metadata">

### Author: ![acaubet](https://discuss-cdn.tryton.org/user_avatar/discuss.tryton.org/acaubet/32/1493_2.png) [@acaubet](https://discuss.tryton.org/u/acaubet)
#### Post date: [July 3, 2024, 12:17pm UTC](https://discuss.tryton.org/t/tax-identifier-configuration-values-not-migrated/7424/2 "2024-07-03T12:17:01Z")

</div>

A problem with saving the migration was causing this, here is the issue and MR:

> **[Migration replace identifiers on configuration not completed (#13387) · Issues...](https://foss.heptapod.net/tryton/tryton/-/issues/13387)**
>
> As explained on https://discuss.tryton.org/t/tax-identifier-configuration-values-not-migrated/7424. The migration for replace\_vat was not completed on the configuration. This is due to a missing...

---

<div class="post-metadata">

### Author: ![dotbit](https://discuss-cdn.tryton.org/user_avatar/discuss.tryton.org/dotbit/32/2093_2.png) [@dotbit](https://discuss.tryton.org/u/dotbit)
#### Post date: [July 3, 2024, 12:56pm UTC](https://discuss.tryton.org/t/tax-identifier-configuration-values-not-migrated/7424/3 "2024-07-03T12:56:49Z")

</div>

> [@acaubet](#):
>
> You can check the ones needed to pick running this query:
> 
> ```auto
> select type from party_identifier where type like '%_vat' group by 1;
> 
> ```

For me your wording is ambiguous.  
My understanding is that if the expected rows of ‘%\_vat’ records is returned, then I my migration is complete.  
In my case, I used to have ro\_cif, now I have ro\_vat, which according to my understanding means complete migration.  
Is my understanding correct?

---

<div class="post-metadata">

### Author: ![acaubet](https://discuss-cdn.tryton.org/user_avatar/discuss.tryton.org/acaubet/32/1493_2.png) [@acaubet](https://discuss.tryton.org/u/acaubet)
#### Post date: [July 3, 2024, 1:16pm UTC](https://discuss.tryton.org/t/tax-identifier-configuration-values-not-migrated/7424/4 "2024-07-03T13:16:30Z")

</div>

The migration of party\_identifier is completed.  
But not the migration for field `party.configuration` on `identifier_types`.  
If use that configuration method and you make this query:  
`select identifier_types from party.configuration`  
you will see the `ro_cf` instead of `ro_vat`.

So if you take a look at any party form view in the identifiers tab you will see ‘ro\_cf’ instead of the typical ‘Romanian VAT Number’.

As you can see on the MR, the problem was a missing save on the migration for party.configuration.

---

<div class="post-metadata">

### Author: ![dotbit](https://discuss-cdn.tryton.org/user_avatar/discuss.tryton.org/dotbit/32/2093_2.png) [@dotbit](https://discuss.tryton.org/u/dotbit)
#### Post date: [July 3, 2024, 1:52pm UTC](https://discuss.tryton.org/t/tax-identifier-configuration-values-not-migrated/7424/5 "2024-07-03T13:52:04Z")

</div>

I remember getting some errors while updating I fixed it manually as I presumed that I had missed some step of the upgrade. Thank you for the clarification.

---

<div class="post-metadata">

### Author: ![system](https://discuss-cdn.tryton.org/uploads/default/original/1X/c6f8ec0a40525cdcd50058c734283450a4b3d38b.png) [@system](https://discuss.tryton.org/u/system)
#### Post date: [July 4, 2024, 1:52am UTC](https://discuss.tryton.org/t/tax-identifier-configuration-values-not-migrated/7424/6 "2024-07-04T01:52:44Z")

</div>

This topic was automatically closed 12 hours after the last reply. New replies are no longer allowed.
