Make sale warehouse not required until processing

[ced (Cédric Krier)]

@pokoli

So we should make it required only when the sale_shipment_cost is activated. Also this is only required when using multiple carriers on when the carrier depend on the source location, if it only depends on the target location the warehouse won’t be needed also.

I do not see the point to make such complex requirement. Also there are probably many other cases where it is needed.

@pokoli

I’m wondering if it won’t be better to make a function field to decide when the warehouse is required or not. This will also ease the customization for thir party modules.

I do not see why.

@pokoli

Our problem is that at the moment of confirming the sale we do not know which warehouse will produce and deliver them. If we set a warehouse at this point the user will not know which sales have been already assigned to a warehouse and which ones have a value that should be changed.

This does not imply that the Tryton design is wrong.
For me your proposal is just based on a single need and not a general need. You imply that the planning of the shipments will only be done at one point in time (the validation) which is very doubtful as we already know Manage planning issues with stock quantity and Improve delivery time - #5 by pokoli.

A general solution is one that permit to adapt the planning any time and based on actual data.
So the wizard I proposed is part of the needed tools but also probably the similar reports as those developed for a warehouse but cross-warehouses.